-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add use-sudo optional parameter defaulting to false. Fixes: #85 #84
Conversation
ac30cae
to
2fe9b69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, just a minor comments
The one failing test failed for |
kind of, because that to install the lib it needs the
in this part: https://github.com/sigstore/cosign-installer/blob/main/action.yml#L208-L223 |
Yep ok, I'll fix this. I should have paid more attention to this failure, sorry about that. |
Signed-off-by: Jason Solis <jsolis@gmail.com>
OK, I can see from before the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Summary
Adds optional input
use-sudo
that can be set totrue
in the case thatinstall-dir
requires sudo privs. The reason for this is that always usingsudo
actually broke ourself-hosted
runners since the user the runner runs as doesn't have sudo privs by security design.Ticket Link
Fixes #85
Release Note